-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ARROW-18072: [C++] Can't use bundled ORC with CMake 3.10 #14432
Conversation
Because CMake 3.10 doesn't support target_link_libraries() against an IMPORTED target: https://cmake.org/cmake/help/latest/release/3.11.html#commands > The target_link_libraries() command learned to set the > INTERFACE_LINK_LIBRARIES property on Imported Targets.
@github-actions crossbow submit test-ubuntu-18.04-cpp* verify-rc-source--ubuntu-18.04- |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1.
Hopefully we can upgrade cmake soon.
We will be able to require CMake 3.16 or later since 12.0.0 because Ubuntu 18.04 will reach EOL at 2023-04. :-) https://wiki.ubuntu.com/Releases
|
Revision: d898447 Submitted crossbow builds: ursacomputing/crossbow @ actions-c6bb247e61 |
Because CMake 3.10 doesn't support target_link_libraries() against an IMPORTED target: https://cmake.org/cmake/help/latest/release/3.11.html#commands > The target_link_libraries() command learned to set the > INTERFACE_LINK_LIBRARIES property on Imported Targets. Authored-by: Sutou Kouhei <kou@clear-code.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Benchmark runs are scheduled for baseline = 9b23bc4 and contender = 66874f5. 66874f5 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
['Python', 'R'] benchmarks have high level of regressions. |
Because CMake 3.10 doesn't support target_link_libraries() against an IMPORTED target:
https://cmake.org/cmake/help/latest/release/3.11.html#commands